Upgrade ndarray and other deps#389
Conversation
.github/workflows/intel-mkl.yml
Outdated
| runs-on: ubuntu-22.04 | ||
| container: | ||
| image: ghcr.io/rust-math/rust-mkl:1.63.0-2020.1 | ||
| image: ghcr.io/rust-math/rust-mkl:1.67.0-2020.1 |
There was a problem hiding this comment.
Thank you for your work. However, I don't think it will work as there's no tag named 1.67-2020.1 for rust-mkl . I'm not sure if we still need to test this container?
Besides, I’m also not certain if the MSRV policy has been implemented. If it’s permitted to bump MSRV, I could also help finish it.
cc @bluss
There was a problem hiding this comment.
Does that mean, we have to update the repository of: https://github.com/rust-math/rust-mkl-container/blob/main/.github/workflows/pack.yml
To provide a docker image with the desired rust version? So we potentially wait for the discussion on MSRV to settle for a specified rust version and than go here for an update in the corresponding rust-mkl repository? Or can we do this already in advance independently to MSRV?
|
Thank you both. @akern40 any thoughts on MSRV? We could make a quick decision to run with a version that's forced by deps here |
|
#390 was almost entirely disjoint from this one, so it went in first. It should make work on this easier. |
|
My two cents on MSRV is that 1) we should have the same MSRV for both |
|
Ok it turns out we'd actually need 1.76 to keep up with |
cguentherTUChemnitz
force-pushed
the
bluss/bump-ndarray
branch
from
a6205ea to
05eff70
Compare
|
@Dirreke I rebased to master with the ci-fix and dropped my commit of the non-existing image releases like: ghcr.io/rust-math/rust-mkl:1.67.0-2020.1. Maybe this helps here to retrigger the pipeline. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #389 +/- ##
==========================================
- Coverage 90.11% 86.88% -3.24%
==========================================
Files 77 64 -13
Lines 4613 3591 -1022
==========================================
- Hits 4157 3120 -1037
- Misses 456 471 +15 ☔ View full report in Codecov by Sentry. |
cguentherTUChemnitz
force-pushed
the
bluss/bump-ndarray
branch
from
05eff70 to
fc0f0ef
Compare
|
As far as i understand, did the cargo fmt commit trigger the codecov job. So i dropped just this one commit. |
|
I think we should rustfmt but ignore codecov warnings for this |
Can this be ignored, when runned as explicit ci-job, that is failing here? Can a maintainer force a merge, even when the coverage job is red? |
|
Yes, it was done that way in #390 too |
|
Thank you for merging this PR! Any plans to tag a stable release of |
5 participants
This is a superset of #386 to provide the missing build environment updates based on the transitive dependency MSRV requirements.
I do not know how to just add the last commit just to the already existing PR without being a maintainer, therefore i just opened this parallel MR containing all the same commits and adding just one commit myself on-top.
best,
Christian